Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests in case-sensitive file system #670

Merged
merged 2 commits into from
Oct 6, 2019
Merged

Fix tests in case-sensitive file system #670

merged 2 commits into from
Oct 6, 2019

Conversation

Qusic
Copy link
Contributor

@Qusic Qusic commented Oct 2, 2019

Replaced IMessage with iMessage in test project files (to be consistent with project.yml).
Also use some different names to enforce renaming on case-insensitive file systems.

@keith
Copy link
Collaborator

keith commented Oct 2, 2019

Moving these files will break this repo in case insensitive file systems. Doing a git pull won't work.

@Qusic
Copy link
Contributor Author

Qusic commented Oct 2, 2019

I agree. But when I cloned this repo, the tests did fail to run. Do you have any suggestions to fix that?

@Qusic
Copy link
Contributor Author

Qusic commented Oct 2, 2019

Updated names in project.yml this time. It works for me and I think it shouldn't break tests elsewhere.

Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Qusic!

@yonaskolb yonaskolb merged commit 2e31065 into yonaskolb:master Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants