Disable Xcode 10.3 CI builds #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
requested changes
Nov 6, 2019
.github/workflows/ci.yml
Outdated
Comment on lines
13
to
34
| - uses: actions/checkout@master | ||
| - name: Set Xcode | ||
| run: | | ||
| echo "Available Xcode versions:" | ||
| ls /Applications | grep Xcode | ||
| echo "Choosing Xcode_${{ matrix.xcode }}.app" | ||
| sudo xcode-select -s /Applications/Xcode_${{ matrix.xcode }}.app | ||
| xcodebuild -version | ||
| swift --version | ||
| swift package --version | ||
| - name: Resolve | ||
| run: swift package resolve | ||
| - name: Build | ||
| run: swift build | ||
| - name: Test | ||
| run: swift test 2>&1 | xcpretty | ||
| - name: Gen fixtures | ||
| run: scripts/gen-fixtures.sh | ||
| - name: Check fixtures | ||
| run: scripts/diff-fixtures.sh | ||
| - name: Build fixtures | ||
| run: scripts/build-fixtures.sh |
There was a problem hiding this comment.
Can we remove the space changes here, and only have the xcode version change? Thanks!
brentleyjones
approved these changes
Nov 6, 2019
|
@yonaskolb I'll let you see if 10.3 can be brought back. |
|
Yeah it's a shame they removed Xcode 10.3. Instead of changing the Xcode version, we should change the Swift version used to compile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't seem to be support for Xcode 10 anymore.
@brentleyjones