Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestAction when debugEnabled: false #725

Conversation

ken0nek
Copy link
Contributor

@ken0nek ken0nek commented Nov 22, 2019

selectedLauncherIdentifier should be Xcode.IDEFoundation.Launcher.PosixSpawn when debugEnabled: false is defined in test

As is

    <TestAction
       buildConfiguration = "Debug"
-      selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
-      selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+      selectedDebuggerIdentifier = ""
+      selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"

To be

    <TestAction
       buildConfiguration = "Debug"
-      selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
-      selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+      selectedDebuggerIdentifier = ""
+      selectedLauncherIdentifier = "Xcode.IDEFoundation.Launcher.PosixSpawn"

@brentleyjones
Copy link
Collaborator

@ken0nek Can you add a changeling entry? Then I'll merge.

@ken0nek
Copy link
Contributor Author

ken0nek commented Nov 23, 2019

@brentleyjones Thank you for your review. I updated it.

@kateinoigakukun kateinoigakukun merged commit 5311147 into yonaskolb:master Nov 23, 2019
@ken0nek ken0nek deleted the work/fix-selectedLauncherIdentifier-on-debugEnabled-false branch November 25, 2019 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants