Fix delayed synchronization #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semin-park
force-pushed
the
48-sync-delay
branch
2 times, most recently
from
9d80433 to
37fc85d
Compare
When envoy proxy goes down and later comes back up, it used to be that the connection does not get automatically reestablished. With this fix, JS client retries to connect to the envoy proxy until it comes back up, and then applies all local changes automatically.
semin-park
force-pushed
the
48-sync-delay
branch
from
1e73d58 to
56331be
Compare
|
@semin-park Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When envoy proxy goes down and later comes back up, it used to be that the connection does not get automatically reestablished.
With this fix, JS clients retries to connect to the envoy proxy until it comes back up, and then applies all local changes automatically.
How should this be manually tested?
docker-compose upto turn onmongo,envoyandyorkie, and thennpm startto start the webpackdevServer)docker stop envoy)docker start envoy)Any background context you want to provide?
c.f. #48
What are the relevant tickets?
Fixes #48
Checklist