Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading wrong .env path #694

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Fix reading wrong .env path #694

merged 2 commits into from
Nov 26, 2023

Conversation

blurfx
Copy link
Member

@blurfx blurfx commented Nov 25, 2023

What this PR does / why we need it?

Fixes an issue that create-yorkie-app reads the wrong path when overwriting the .env.

Any background context you want to provide?

What are the relevant tickets?

Fixes #690

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@blurfx blurfx requested a review from hackerwins November 25, 2023 14:59
@blurfx blurfx self-assigned this Nov 25, 2023
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e34144) 69.12% compared to head (16d8442) 69.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #694      +/-   ##
==========================================
- Coverage   69.12%   69.10%   -0.03%     
==========================================
  Files          58       58              
  Lines        8787     8787              
  Branches      800      800              
==========================================
- Hits         6074     6072       -2     
- Misses       2454     2455       +1     
- Partials      259      260       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 4bbdf2e into main Nov 26, 2023
1 check passed
@hackerwins hackerwins deleted the fix/create-yorkie-app branch November 26, 2023 00:20
@hackerwins
Copy link
Member

It works!!
Screenshot 2023-11-26 at 10 16 11 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants