Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typos in the installation command on README.md in the example #702

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

ymw0407
Copy link
Contributor

@ymw0407 ymw0407 commented Nov 30, 2023

What this PR does / why we need it?

This PR change typo error on example's REAMD.md!

$ docker-compose up -f docker/docker-compose.yml up 

to

$ docker-compose -f docker/docker-compose.yml up 

Any background context you want to provide?

Maybe I'm mistaken because I don't know much about docker complex, but when I run it, it runs well when there's no up in front of it!

What are the relevant tickets?

Fixes #701

Checklist

  • Added relevant tests or not required
  • Didn't break anything

The contents of 'How to run demo' have changed as follows
docker-compose up -f ... --> docker-compose -f ...

Signed-off-by: ymw0407 <[email protected]>
The contents of 'How to run demo' have changed as follows
docker-compose up -f ... --> docker-compose -f ...

Signed-off-by: ymw0407 <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Nov 30, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@krapie krapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing these typos!
Never thought of these typos 😅

@ymw0407
Copy link
Contributor Author

ymw0407 commented Nov 30, 2023

Thank you for maintaining this great project! 😄

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3db9d59) 69.11% compared to head (9c61ff9) 69.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #702   +/-   ##
=======================================
  Coverage   69.11%   69.11%           
=======================================
  Files          58       58           
  Lines        8787     8787           
  Branches      800      800           
=======================================
  Hits         6073     6073           
  Misses       2454     2454           
  Partials      260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins merged commit 41f5b2f into yorkie-team:main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo error on Examples!
4 participants