Add removeIfNotAttached to client.detach() options
#703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #703 +/- ##
==========================================
+ Coverage 69.11% 69.13% +0.01%
==========================================
Files 58 58
Lines 8787 8789 +2
Branches 800 802 +2
==========================================
+ Hits 6073 6076 +3
+ Misses 2454 2453 -1
Partials 260 260 ☔ View full report in Codecov by Sentry. |
hackerwins
approved these changes
Dec 1, 2023
hackerwins
changed the title
removeIfNotAttached to client.detach() optionremoveIfNotAttached to client.detach() options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Add
removeIfNotAttachedtoclient.detach()option(Ref: Go-SDK yorkie-team/yorkie#560)
Does this PR introduce a user-facing change?:
When the
removeIfNotAttachedoption is set during detaching, the document will be removed after detaching only if there are no other clients simultaneously editing the document (i.e., no clients are currently attached). The default setting forremoveIfNotAttachedisfalse.Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist