Read Cargo.toml from target dir #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bltavares
force-pushed
the
read-cargo-from-dir
branch
from
57b7ce6 to
badfad2
Compare
yoshuawuyts
reviewed
Oct 11, 2018
src/main.rs
Outdated
| use structopt::StructOpt; | ||
|
|
||
| fn main() -> Result<(), ExitFailure> { | ||
| setup_panic!(); | ||
| let args = Cli::from_args(); | ||
| args.log(env!("CARGO_PKG_NAME"))?; | ||
|
|
||
| let dir = args.dir()?; | ||
| let dir: PathBuf = args.dir()?; |
There was a problem hiding this comment.
Most likely not. I thought I was doing type conversion from string to pathbuf, because I looked at the wrong property on cli.rs. I'll remove this.
|
@bltavares this patch looks pretty good! -- ideally we could have some regression test for this too, but we don't have a test framework setup yet, so it might be a bit odd. Is this something you'd be okay with adding? |
|
@yoshuawuyts I wouldn't be able to setup the testing harness soon enough, but I could help with that in a near future, if that is ok for you. |
When running `crossgen` on a directory with a missing `Cargo.toml` it would panic with an error message. Debugging what happend, I've found it failed to find a `Cargo.toml` file, as it don't exist. To my surprise, when I've cloned the repo and tried to reproduce using `cargo run -- ~/path/to/my-dir`, there was no panic! This happened because the `Cargo.toml` was found on `crossgen` repo, not on my targe repo, as expected. This commit changes the location of the manifest file to use the directory parsed from the arguments. Signed-off-by: Bruno Tavares <[email protected]>
bltavares
force-pushed
the
read-cargo-from-dir
branch
from
badfad2 to
7690cad
Compare
yoshuawuyts
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
crossgenon a directory with a missingCargo.tomlitwould panic with an error message.
Debugging what happend, I've found it failed to find a
Cargo.tomlfile, as it don't exist.To my surprise, when I've cloned the repo and tried to reproduce using
cargo run -- ~/path/to/my-dir, there was no panic!This happened because the
Cargo.tomlwas found oncrossgenrepo, not on my targe repo, as expected.This commit changes the location of the manifest file to use the directory parsed from the arguments.
Choose one: is this a 🐛 bug fix, a 🙋 feature, or a 🔦 documentation change?
🐛
Checklist
Context
Related issue while debugging: rust-cli/human-panic#30 (comment) and #16
Semver Changes