Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #135: check if Future has completed before polling it #136

Conversation

matheus-consoli
Copy link
Collaborator

Fix #135, we're missing the check before polling.

@matheus-consoli matheus-consoli force-pushed the issue-135-resume-after-completion branch from 1f7caa8 to 9430a9d Compare May 16, 2023 17:39
Copy link
Owner

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you!

@yoshuawuyts yoshuawuyts merged commit 6e6bba3 into yoshuawuyts:main May 22, 2023
@matheus-consoli matheus-consoli deleted the issue-135-resume-after-completion branch May 23, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TryJoin2 polls completed futures
2 participants