Improve Color Theme Copy Feature (radareorg#1560)

yossizap · May 19, 2019 · 822034b · 822034b
1 parent 2012637
commit 822034b
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/src/dialogs/preferences/AppearanceOptionsWidget.cpp b/src/dialogs/preferences/AppearanceOptionsWidget.cpp
@@ -126,12 +126,19 @@ void AppearanceOptionsWidget::on_copyButton_clicked()
     do {
         newThemeName = QInputDialog::getText(this, tr("Enter theme name"),
                                              tr("Name:"), QLineEdit::Normal,
-                                             currColorTheme + tr(" - copy"));
-    } while (!newThemeName.isEmpty() && ThemeWorker().isThemeExist(newThemeName));
+                                             currColorTheme + tr(" - copy"))
+                       .trimmed();
+        if (newThemeName.isEmpty()) {
+            return;
+        }
+        if (ThemeWorker().isThemeExist(newThemeName)) {
+            QMessageBox::information(this, tr("Theme Copy"),
+                                     tr("Theme named %1 already exists.").arg(newThemeName));
+        } else {
+            break;
+        }
+    } while (true);
 
-    if (newThemeName.isEmpty()) {
-        return;
-    }
     ThemeWorker().copy(currColorTheme, newThemeName);
     Config()->setColorTheme(newThemeName);
     updateThemeFromConfig(false);