Merge pull request #896 from utam0k/fix/notify-close

How many times in my life do I have to repeat forgetting close?

crates/libcontainer/src/notify_socket.rs

@@ -48,7 +48,7 @@ impl NotifyListener {
         Ok(())
     }
 
-    pub fn close(&mut self) -> Result<()> {
+    pub fn close(&self) -> Result<()> {
         close(self.socket.as_raw_fd())?;
         Ok(())
     }
@@ -75,9 +75,4 @@ impl NotifySocket {
         unistd::chdir(&cwd)?;
         Ok(())
     }
-
-    pub fn notify_container_finish(&mut self) -> Result<()> {
-        // self.socket.write_all(b"finish container")?;
-        Ok(())
-    }
 }

crates/libcontainer/src/process/container_init_process.rs

@@ -401,6 +401,7 @@ pub fn container_init_process(
 
     // listing on the notify socket for container start command
     args.notify_socket.wait_for_container_start()?;
+    args.notify_socket.close()?;
 
     // create_container hook needs to be called after the namespace setup, but
     // before pivot_root is called. This runs in the container namespaces.