Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag --log is broken? #475

Closed
tiqwab opened this issue Nov 14, 2021 · 2 comments · Fixed by #511
Closed

Flag --log is broken? #475

tiqwab opened this issue Nov 14, 2021 · 2 comments · Fixed by #511
Assignees

Comments

@tiqwab
Copy link
Contributor

tiqwab commented Nov 14, 2021

I found that the current youki can't write logs to a file.

$ sudo ./youki --log /tmp/youki.log create -b ~/workspace/tmp/mycontainer mycontainer

# file is created, but empty
$ ls -l /tmp/youki.log
-rw-r--r-- 1 root root 0 Nov 14 12:45 /tmp/youki.log

youki uses env_logger, but env_logger::Target::Pipe is broken according to rust-cli/env_logger#208.

@Furisto
Copy link
Collaborator

Furisto commented Nov 16, 2021

I had noticed this too, but hoped that env_logger fixes this soonTM.

@yihuaf
Copy link
Collaborator

yihuaf commented Nov 18, 2021

Hmm this is unfortunate... I was hoping env_logger to be more stable and save us the boilerplate. Let me take this issue and see if we should just revert to having our own logger implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants