Fix log files and remove env_logger #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove env_logger and use our own logger
Codecov Report
@@ Coverage Diff @@
## main #511 +/- ##
==========================================
+ Coverage 60.54% 60.92% +0.38%
==========================================
Files 86 86
Lines 12604 12651 +47
==========================================
+ Hits 7631 7708 +77
+ Misses 4973 4943 -30 |
utam0k
reviewed
Dec 1, 2021
Comment on lines
+78
to
+79
| /// Indicates level up to which logs are to be printed | ||
| level: Option<log::Level>, |
There was a problem hiding this comment.
None means logging is disabled. None is returned by to_level if a logging level of 'Off' is specified.
Furisto
approved these changes
Dec 1, 2021
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #475
As mentioned in #475, the log file is broken due to env_logger breaks. Originally we were hoping using env_logger can save us from maintaining our own logger, but it seems that env_logger is not a good fit. While there is an issue filed with env_logger to fix file logging target, it is unlikely to be fixed in a reasonable time frame.
For logger, we require:
For now, let's fall back to use our own logger implementation. It is simple enough and fits our use case. I am surprised that there is no good out of box logger for Rust similar to
logrusfor Golang. Most of the logging libraries in Rust either lacks features or is not well maintained. https://github.com/tokio-rs/tracing seems to be a promising substitute forlogin rust, but it requires more work.