Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically publish packages #1000

Merged
merged 5 commits into from
Jul 9, 2022
Merged

Conversation

MostlyAmiable
Copy link
Contributor

@MostlyAmiable MostlyAmiable commented Jun 21, 2022

I just published rust-criu, which I believe was the last blocker to getting youki's packages published. I added an additional job to the release action so that new versions will get published automatically, just need to add a token to the repo secrets under CARGO_REGISTRY_TOKEN. I used --no-verify because it's already verified as part of the check job, and I removed the documentation attribute from the manifests because they default to docs.rs.

Ref: #586

@utam0k
Copy link
Member

utam0k commented Jun 21, 2022

@MostlyAmiable Thanks for your PR. You got a lucky number #1000. It seems òci-spec-rs` is failed because the maintainer(it's me) doesn't release a new version 😭
I'll deal with the oci-spec-rs part later, so could you please remove that part from this PR? Of course you can do it.

Signed-off-by: Benjamin Levin <[email protected]>
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@utam0k
Copy link
Member

utam0k commented Jun 23, 2022

@MostlyAmiable There are still several oci-spec-rs that are version-specific.

@MostlyAmiable
Copy link
Contributor Author

@utam0k Woops, sorry for the oversight and the delayed response. Does it make sense to wait to merge these changes until we can depend on a published version of oci-spec-rs, since otherwise we still can't publish these crates as long as they have git dependencies?

@utam0k
Copy link
Member

utam0k commented Jul 6, 2022

@MostlyAmiable Please wait for merging this PR
youki-dev/oci-spec-rs#108

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2022

Codecov Report

Merging #1000 (81f4608) into main (c43f701) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1000   +/-   ##
=======================================
  Coverage   69.24%   69.24%           
=======================================
  Files         118      118           
  Lines       12439    12439           
=======================================
  Hits         8613     8613           
  Misses       3826     3826           

@utam0k
Copy link
Member

utam0k commented Jul 8, 2022

@MostlyAmiable Can I ask you to pass the CIs?

$ git commit --amend --no-edit -s

Signed-off-by: Benjamin Levin <[email protected]>
Signed-off-by: Benjamin Levin <[email protected]>
@MostlyAmiable
Copy link
Contributor Author

Is the intent of the DCO signoff not implied by the fact that I'm contributing code under the Apache 2.0 license?

@MostlyAmiable
Copy link
Contributor Author

Feel free to merge after approving/passing workflows, it's a race between me and dependabot bumping dependency versions 😅

@utam0k
Copy link
Member

utam0k commented Jul 9, 2022

Is the intent of the DCO signoff not implied by the fact that I'm contributing code under the Apache 2.0 license?

This is a process just in case. Thanks for your cooperation.

@utam0k
Copy link
Member

utam0k commented Jul 9, 2022

@MostlyAmiable Thanks! 💯

@utam0k utam0k merged commit ba96493 into youki-dev:main Jul 9, 2022
@MostlyAmiable MostlyAmiable deleted the publish-action branch July 11, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants