-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically publish packages #1000
Conversation
@MostlyAmiable Thanks for your PR. You got a lucky number #1000. It seems òci-spec-rs` is failed because the maintainer(it's me) doesn't release a new version 😭 |
Signed-off-by: Benjamin Levin <[email protected]>
Signed-off-by: Benjamin Levin <[email protected]>
09406e5
to
50004ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@MostlyAmiable There are still several oci-spec-rs that are version-specific. |
@utam0k Woops, sorry for the oversight and the delayed response. Does it make sense to wait to merge these changes until we can depend on a published version of |
@MostlyAmiable Please wait for merging this PR |
50004ba
to
b816bfa
Compare
Codecov Report
@@ Coverage Diff @@
## main #1000 +/- ##
=======================================
Coverage 69.24% 69.24%
=======================================
Files 118 118
Lines 12439 12439
=======================================
Hits 8613 8613
Misses 3826 3826 |
@MostlyAmiable Can I ask you to pass the CIs? $ git commit --amend --no-edit -s |
Signed-off-by: Benjamin Levin <[email protected]>
Signed-off-by: Benjamin Levin <[email protected]>
…sh-action Signed-off-by: Benjamin Levin <[email protected]>
b9627fb
to
81f4608
Compare
Is the intent of the DCO signoff not implied by the fact that I'm contributing code under the Apache 2.0 license? |
Feel free to merge after approving/passing workflows, it's a race between me and dependabot bumping dependency versions 😅 |
This is a process just in case. Thanks for your cooperation. |
@MostlyAmiable Thanks! 💯 |
I just published
rust-criu
, which I believe was the last blocker to getting youki's packages published. I added an additional job to the release action so that new versions will get published automatically, just need to add a token to the repo secrets underCARGO_REGISTRY_TOKEN
. I used--no-verify
because it's already verified as part of thecheck
job, and I removed thedocumentation
attribute from the manifests because they default to docs.rs.Ref: #586