Add git commit sha placeholder if .git not found #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1251 +/- ##
==========================================
- Coverage 69.21% 69.21% -0.01%
==========================================
Files 118 118
Lines 12514 12514
==========================================
- Hits 8662 8661 -1
- Misses 3852 3853 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1212
Not sure if we actively support building through nix, and as the issue discussion states, it is not fully working either even with this change.
This will emit a placeholder sha of
unknownand add continue-on-error option for vergen. Currently the only place we are using sha is in info and version cli commands. If .git is found, vergen overrides theunknownby actual sha. I have verified this, but if possible, someone else also verify once.