libcontainer: make device creation interfaces public #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ismo Puustinen <[email protected]>
ipuustin
force-pushed
the
public-device-functions
branch
from
4ee6cc6 to
c77dd2c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1578 +/- ##
==========================================
- Coverage 68.86% 68.86% -0.01%
==========================================
Files 120 120
Lines 13058 13058
==========================================
- Hits 8993 8992 -1
- Misses 4065 4066 +1 |
|
Making Device public seems ok. I am hesitant add another feature flag to the crate as we already have quite a few and I do not want complicate it further without having a strong demand for this. How about we add a |
|
I think |
Furisto
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm investigating how to implement device file support to runwasi in this PR: containerd/runwasi#68. In order to use libcontainer functions for device file creation, they would need to be public for use from other crates. I would be happy to hear feedback regarding whether or not this is the right way to approach this problem.
Another question has to do with the libcontainer test mocks. The libcontainer device creating functions, when compiled in test configuration, know how to mock system calls. Is there a way for exposing that to users outside of the crate too? Maybe having a different libcontainer feature selected in dev-dependencies?