Implement basic foreground mode #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1656 +/- ##
==========================================
- Coverage 68.95% 68.87% -0.09%
==========================================
Files 120 120
Lines 13156 13174 +18
==========================================
+ Hits 9072 9073 +1
- Misses 4084 4101 +17 |
yihuaf
force-pushed
the
yihuaf/foreground
branch
from
6d909b9 to
f79ab01
Compare
utam0k
reviewed
Mar 15, 2023
utam0k
reviewed
Mar 15, 2023
utam0k
reviewed
Mar 15, 2023
Signed-off-by: Eric Fang <[email protected]>
Signed-off-by: Eric Fang <[email protected]>
Signed-off-by: Eric Fang <[email protected]>
yihuaf
force-pushed
the
yihuaf/foreground
branch
from
f79ab01 to
784a5c7
Compare
Signed-off-by: Eric Fang <[email protected]>
utam0k
approved these changes
Mar 17, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports basic foreground mode where the youki main process will wait for the container process to exit. A basic foreground signal forwarding is implemented to match the behavior of
runc. This PR includes the structure of the signal forwarder, but not every details is matched toruncyet.Fix #1627
Fix #317
Fix #628