Implement events command for cgroup v1 stats #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utam0k
reviewed
Jul 31, 2021
src/cgroups/v1/memory.rs
Outdated
Comment on lines
169
to
172
| let enabled = match hierarchy.trim() { | ||
| "1" => true, | ||
| _ => false, | ||
| }; |
There was a problem hiding this comment.
Suggested change
| let enabled = match hierarchy.trim() { | |
| "1" => true, | |
| _ => false, | |
| }; | |
| let enabled = matches!(hierarchy.trim(), "1"); |
utam0k
reviewed
Jul 31, 2021
src/cgroups/v1/blkio.rs
Outdated
Comment on lines
141
to
145
| let mut stats = BlkioStats::default(); | ||
|
|
||
| stats.service_bytes = | ||
| Self::parse_blkio_file(&cgroup_path.join(BLKIO_THROTTLE_IO_SERVICE_BYTES))?; | ||
| stats.serviced = Self::parse_blkio_file(&cgroup_path.join(BLKIO_THROTTLE_IO_SERVICED))?; |
There was a problem hiding this comment.
https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
Suggested change
| let mut stats = BlkioStats::default(); | |
| stats.service_bytes = | |
| Self::parse_blkio_file(&cgroup_path.join(BLKIO_THROTTLE_IO_SERVICE_BYTES))?; | |
| stats.serviced = Self::parse_blkio_file(&cgroup_path.join(BLKIO_THROTTLE_IO_SERVICED))?; | |
| let stats = BlkioStats { | |
| service_bytes: Self::parse_blkio_file( | |
| &cgroup_path.join(BLKIO_THROTTLE_IO_SERVICE_BYTES), | |
| )?, | |
| serviced: Self::parse_blkio_file(&cgroup_path.join(BLKIO_THROTTLE_IO_SERVICED))?, | |
| ..Default::default() | |
| }; |
utam0k
requested changes
Jul 31, 2021
|
@utam0k Updated with your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.