Fix stop container when prestart hook fails. #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Fang <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1745 +/- ##
==========================================
- Coverage 68.69% 68.63% -0.06%
==========================================
Files 121 121
Lines 13314 13318 +4
==========================================
- Hits 9146 9141 -5
- Misses 4168 4177 +9 |
YJDoc2
reviewed
Mar 30, 2023
YJDoc2
approved these changes
Mar 30, 2023
Co-authored-by: Yashodhan <[email protected]> Signed-off-by: Eric Fang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #498
This is long overdue. This PR only aims to fix the pre-start hook case. I will review all the other hook case to match the lifecycle spec of the runtime spec.