Implemented hooks #187
Implemented hooks #187
Conversation
|
@yihuaf Could you add the hooks-related integration tests for runtime-tools? |
The OCI spec needs the container state to pipe in through stdin
|
@utam0k PTAL |
| @@ -35,6 +35,7 @@ systemd = { version = "0.8", default-features = false, optional = true } | |||
| dbus = "0.9.2" | |||
| tabwriter = "1" | |||
| fastrand = "1.4.1" | |||
| crossbeam-channel = "0.5" | |||
There was a problem hiding this comment.
Is there any way to narrow down the features?
https://github.com/crossbeam-rs/crossbeam/blob/02e74146ca0b871974fccda579911bf57a9c0ea9/Cargo.toml#L18-L41
There was a problem hiding this comment.
I think we already do. If I understand how this crate works, there is crossbeam with feature ("crossbeam-channel/std" for example), or use crossbeam-channel directly. crossbeam with feature "crossbeam-channel/std" seems to point to crossbeam-channel underneath.
For context, to be honest, I only used crossbeam because std::sync::mpsc documentation here mentioned this unfixed issue where it mentioned crossbeam being a potential replacement for the std::sync::mpsc,
Co-authored-by: utam0k <[email protected]>
|
@yihuaf Thanks! |
Fix #13 Fix #201
Note: I leftPreStarthooks out since the spec mentioned that it is deprecated. Adding it takes no effort in the future.Edit: I have to add this since integration and docker seems to use this.
Note2: I disabled
preserve-fdsforexecdue to #185, so at least this code can be tested manually. This will be fixed immediatly afterwards.Note3: We may have to do a refactor to re-org the code a little bit, but probably should do it in a different PR.