Add easy way to test with K8s #1884
Conversation
Signed-off-by: utam0k <[email protected]>
| image: nginx:1.16.1 | ||
| ports: | ||
| - containerPort: 80 | ||
| automountServiceAccountToken: false |
There was a problem hiding this comment.
Deleting this line, unfortunately, youki gives an error 😭
There was a problem hiding this comment.
Do you have an idea why? We should track this as an issue.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1884 +/- ##
==========================================
- Coverage 67.70% 67.70% -0.01%
==========================================
Files 124 124
Lines 14205 14206 +1
==========================================
Hits 9618 9618
- Misses 4587 4588 +1 |
Signed-off-by: utam0k <[email protected]>
| echo "CONTAINERD_NAMESPACE='default'" | sudo tee /etc/systemd/system/k3s-runwasi.service.env && \ | ||
| echo "NO_PROXY=192.168.0.0/16" | sudo tee -a /etc/systemd/system/k3s-runwasi.service.env && \ | ||
| sudo systemctl daemon-reload && \ | ||
| sudo systemctl restart k3s-youki && \ |
There was a problem hiding this comment.
In general, I recommend separate the install step from the actual test step. We can create a prepare target that sets up the k3s environment for the test, then make test should only check the dependency and run the test. In this way, the test can run multiple times without repeating the install step.
There was a problem hiding this comment.
@YJDoc2 Since I can't take any more time today, but I don't want to interrupt your work, can I ask you to fix it with just PR?
| @@ -204,7 +204,7 @@ pub fn container_init_process( | |||
| // before pivot_root is called. This runs in the container namespaces. | |||
| if let Some(hooks) = hooks { | |||
| hooks::run_hooks(hooks.create_container().as_ref(), container) | |||
| .context("Failed to run create container hooks")?; | |||
| .context("failed to run create container hooks")?; | |||
There was a problem hiding this comment.
We don't need this since these will be replaced with thiserror. Same for the others as well.
There was a problem hiding this comment.
Prioritize the merge for subsequent work 🙇
| image: nginx:1.16.1 | ||
| ports: | ||
| - containerPort: 80 | ||
| automountServiceAccountToken: false |
There was a problem hiding this comment.
Do you have an idea why? We should track this as an issue.
|
@yihuaf The work is almost done, however I will take today/tomorrow to update the PR. In any case this should not be stopped for justfile. I'll update my PR for these changes as needed. Once this is ready to go, please merge without waiting on Justfile PR 👍 |
You can confirm this script:
Relates: #730