Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add information about the pronunciation and the etymology of youki #19

Merged
merged 2 commits into from
May 22, 2021

Conversation

yuchiki
Copy link
Contributor

@yuchiki yuchiki commented May 22, 2021

youki is unquestionably a smart name that describes the very concept of the container.
However, it seems to be a little bit difficult for non-native Japanese speaker to guess its pronunciation and what 'youki' means.
This PR adds some explanation about the pronunciation of youki and the meanings term 'youki' carries in Japanese language.

@utam0k
Copy link
Member

utam0k commented May 22, 2021

@yuchiki
Thanks for you contibute!
I think it's very important to explain the origin and pronunciation of the name.
How about adding a section called About the Name?

@yuchiki
Copy link
Contributor Author

yuchiki commented May 22, 2021

How about adding a section called About the Name?

Sounds nice. I modified this PR as you said.

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!!

@utam0k utam0k merged commit 50eeceb into youki-dev:main May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants