Add some clean up that improves coverage #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1963 +/- ##
==========================================
+ Coverage 65.02% 65.31% +0.28%
==========================================
Files 129 129
Lines 14731 14746 +15
==========================================
+ Hits 9579 9631 +52
+ Misses 5152 5115 -37 |
utam0k
reviewed
May 26, 2023
| @@ -38,7 +38,7 @@ impl Executor for DefaultExecutor { | |||
| ExecutorError::Execution(err.into()) | |||
| })?; | |||
|
|
|||
| // After do_exec is called, the process is replaced with the container | |||
There was a problem hiding this comment.
Sorry, I forgot to delete them 😭
utam0k
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some code that are no longer used.