Add new setup_envs method for the Executor trait
#2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kotaro Inoue <[email protected]>
Signed-off-by: Kotaro Inoue <[email protected]>
|
cc: @Mossaka |
Signed-off-by: Kotaro Inoue <[email protected]>
Signed-off-by: Kotaro Inoue <[email protected]>
Signed-off-by: Kotaro Inoue <[email protected]>
Mossaka
reviewed
Jun 21, 2024
utam0k
reviewed
Jun 21, 2024
Comment on lines
75
to
76
| /// Set environment variables for the container process to be executed. | ||
| fn set_envs(&self, envs: HashMap<String, String>) -> Result<(), ExecutorSetEnvsError> { |
There was a problem hiding this comment.
I don't think set is a proper word for this method because we need to delete and add the envs. How about update or setup?
There was a problem hiding this comment.
setup_envs sounds good to me. Let me rename the method and related type names.
There was a problem hiding this comment.
I've renamed in 9fbeef5
| @@ -60,6 +71,16 @@ pub trait Executor: CloneBoxExecutor { | |||
| /// namespace and cgroups, and pivot_root into the rootfs. But this step | |||
| /// runs before waiting for the container start signal. | |||
| fn validate(&self, spec: &Spec) -> Result<(), ExecutorValidationError>; | |||
|
|
|||
| /// Set environment variables for the container process to be executed. | |||
There was a problem hiding this comment.
It'd be better to explain the situation this method is called. For example, this method is called the init process and hasn't cleared the host's envs yet.
There was a problem hiding this comment.
I've added a detailed description for the setup_envs in b20b8fa.
Signed-off-by: Kotaro Inoue <[email protected]>
Signed-off-by: Kotaro Inoue <[email protected]>
musaprg
changed the title
set_envs method for the Executor traitsetup_envs method for the Executor trait
Merged
|
@musaprg Congrats! 🎉 Thanks for your contribution. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2815
This PR introduces a new
setup_envsmethod for theExecutortrait. It allows any implementors of theExecutortrait to control how environment variables specified in the OCI spec are handled. The default implementation mirrors the behavior of the one implemented in thecontainer_init_process, which involves removing existing environment variables and setting the ones specified in the OCI spec.TODO
ExecutorError