Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply building best practices to .devcontainer/Dockerfile #2856

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

keisku
Copy link
Contributor

@keisku keisku commented Jul 21, 2024

@utam0k utam0k self-requested a review July 21, 2024 11:15
@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 21, 2024
RUN rustup install nightly
RUN rustup component add rustfmt
RUN rustup component add clippy
RUN <<EOF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@utam0k utam0k enabled auto-merge (squash) July 21, 2024 11:27
@utam0k
Copy link
Member

utam0k commented Jul 21, 2024

@keisku Thanks for your first contribution! I'm looking forward following your PRs ;)

@utam0k utam0k merged commit 68a5e84 into youki-dev:main Jul 21, 2024
29 of 30 checks passed
@github-actions github-actions bot mentioned this pull request Jul 21, 2024
@github-actions github-actions bot mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants