Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-test-linux_rootfs_propagation #3024

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saku3
Copy link
Contributor

@saku3 saku3 commented Dec 15, 2024

This implements the validation linux_rootfs_propagation in #361

@saku3
Copy link
Contributor Author

saku3 commented Dec 16, 2024

I'm not sure if this is related, but this issue might be relevant:
opencontainers/runc#1755

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Jan 2, 2025

Hey, thanks for the PR! I will try to take a look soon. In the meantime, can you rebase on main and fix the conflicts? Thanks!

@saku3 saku3 force-pushed the add-test-linux_rootfs_propagation branch from 2979c20 to c87a97e Compare January 2, 2025 10:15
@utam0k
Copy link
Member

utam0k commented Jan 6, 2025

It appears not to pass CI. May I ask you to check it?

@utam0k utam0k self-assigned this Jan 6, 2025
@saku3
Copy link
Contributor Author

saku3 commented Jan 6, 2025

@utam0k @YJDoc2

When I run just validate-contest-runc locally, it fails in the same way as in the CI.(rootfs_propagation_shared_test)

# Start group rootfs_propagation
1 / 4 : rootfs_propagation_private_test : ok
2 / 4 : rootfs_propagation_shared_test : not ok
        container stderr was not empty, found : Error: shared root propagation failed to expose "/tmp/target9AGYIG/tmp/mountJk8Iig/example"

3 / 4 : rootfs_propagation_slave_test : ok
4 / 4 : rootfs_propagation_unbindable_test : ok
# End group rootfs_propagation

I also checked the following issue, but I'm not sure if it's related:
opencontainers/runc#1755

I will continue investigating this on my side, but I would appreciate any advice you could provide.

@utam0k
Copy link
Member

utam0k commented Jan 7, 2025

@saku3 Let me make sure the premise that runtime-tools only tests if the container comes up with shared option, right?
How about referring to runc's e2e?
https://github.com/opencontainers/runc/blob/81b13172bea2e6e4cf50f6bdd29a5fdeb5a6acf5/libcontainer/integration/exec_test.go#L1240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants