-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rootful mode for vagrant #324
Conversation
Codecov Report
@@ Coverage Diff @@
## main #324 +/- ##
==========================================
+ Coverage 70.94% 70.96% +0.01%
==========================================
Files 46 46
Lines 6832 6832
==========================================
+ Hits 4847 4848 +1
+ Misses 1985 1984 -1 |
@zidoshare Thanks for your PR. I feel that we only support root full mode; is there any good point in continuing to support the two vagrant environments? |
@utam0k On the other hand, when we add new features, we always debug successfully in root full mode before adding patches to rootless mode. So I think there should be two modes for selective development, and they do not conflict with each other. |
I understand. It's not that costly to support at the moment, so let's support it. Please fix only what I commented. |
I know, but I found some errors, please wait a while, I am fixing it @utam0k |
done. @utam0k |
5b6f31d
to
8e7294c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thasnks
I added a rootful development mode to vagrant, which may provide us with convenience for debugging in vagrant using a similar vscode editor remote ssh.
It is very simple to use, like the following: