Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootful mode for vagrant #324

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Conversation

zidoshare
Copy link
Contributor

@zidoshare zidoshare commented Sep 23, 2021

I added a rootful development mode to vagrant, which may provide us with convenience for debugging in vagrant using a similar vscode editor remote ssh.

It is very simple to use, like the following:

VAGRANT_VAGRANTFILE=Vagrantfile.root vagrant up

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #324 (66e711b) into main (ae4b197) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
+ Coverage   70.94%   70.96%   +0.01%     
==========================================
  Files          46       46              
  Lines        6832     6832              
==========================================
+ Hits         4847     4848       +1     
+ Misses       1985     1984       -1     

@zidoshare zidoshare changed the title Add rootful mode rootful mode for vagrant Sep 23, 2021
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@utam0k
Copy link
Member

utam0k commented Sep 23, 2021

@zidoshare Thanks for your PR. I feel that we only support root full mode; is there any good point in continuing to support the two vagrant environments?

@zidoshare
Copy link
Contributor Author

@utam0k
We may pay more attention to the support of rootless mode than root full, because it is more secure, which is as attractive as no daemon.

On the other hand, when we add new features, we always debug successfully in root full mode before adding patches to rootless mode.

So I think there should be two modes for selective development, and they do not conflict with each other.

@utam0k
Copy link
Member

utam0k commented Sep 23, 2021

@utam0k
We may pay more attention to the support of rootless mode than root full, because it is more secure, which is as attractive as no daemon.

On the other hand, when we add new features, we always debug successfully in root full mode before adding patches to rootless mode.

So I think there should be two modes for selective development, and they do not conflict with each other.

I understand. It's not that costly to support at the moment, so let's support it. Please fix only what I commented.

@zidoshare
Copy link
Contributor Author

I know, but I found some errors, please wait a while, I am fixing it @utam0k

@zidoshare
Copy link
Contributor Author

zidoshare commented Sep 23, 2021

done. @utam0k

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thasnks

@utam0k utam0k merged commit 4275b51 into youki-dev:main Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants