Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various refactorings #341

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Add various refactorings #341

merged 1 commit into from
Sep 27, 2021

Conversation

tranzystorekk
Copy link
Contributor

Highlights:

  • Remove or simplify redundant code, like &*, .as_ref(), etc.
  • Use IntoIterator to avoid some invocations like .iter()
  • Simplify some Option-oriented code

@codecov-commenter
Copy link

Codecov Report

Merging #341 (8635188) into main (bc5b6fd) will increase coverage by 0.22%.
The diff coverage is 43.15%.

@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
+ Coverage   70.13%   70.35%   +0.22%     
==========================================
  Files          46       46              
  Lines        6756     6737      -19     
==========================================
+ Hits         4738     4740       +2     
+ Misses       2018     1997      -21     

Copy link
Collaborator

@yihuaf yihuaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for doing this.

@yihuaf yihuaf merged commit 8250b48 into youki-dev:main Sep 27, 2021
@tranzystorekk tranzystorekk deleted the refactor-v1 branch September 27, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants