part of PR 340 moving syscalls into structure #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #357 +/- ##
==========================================
- Coverage 68.83% 68.55% -0.28%
==========================================
Files 48 48
Lines 7181 7210 +29
==========================================
Hits 4943 4943
- Misses 2238 2267 +29 |
utam0k
reviewed
Oct 4, 2021
src/rootfs.rs
Outdated
| Some(uknown) => bail!("unknown rootfs_propagation: {}", uknown), | ||
| /// Holds information about rootfs | ||
| pub struct RootFS { | ||
| command: Box<dyn Syscall>, |
There was a problem hiding this comment.
Sorry, this s mixed up by my mistake, but let's unify the name to syscall.
There was a problem hiding this comment.
Do you mean the field name from command to syscall?
or something else, please guide.
There was a problem hiding this comment.
Let's simply change the name command to syscall.
|
@tommady This PR just uses Syscalls so that mocks can be used, right? |
yes correctly! |
|
@tommady Thanks for always separating the PR from the rest. It makes it easier for me to review them :) |
tommady
deleted the
279-increate-the-code-coverage-of-src-rootfs-part-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as requested by separating #340 into small PRs
this one is the second part of moving all system calls into a RootFS structure to make them mockable.
please help review 🙇🏻