part of PR 340 adding test_bind_dev,test_mknod_dev and test_create_devices #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry, the test failures are some kind of I don't understand... cargo test --all --all-features --no-fail-fast
/build-script-build` (exit status: 101)
--- stdout
MKDIR staticobjs
CC bpf.o
CC btf.o
--- stderr
Package libelf was not found in the pkg-config search path.
Perhaps you should add the directory containing `libelf.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libelf' found
btf.c:18:10: fatal error: gelf.h: No such file or directory
18 | #include <gelf.h>
| ^~~~~~~~
compilation terminated.
make: *** [Makefile:113: /home/tommady/rust/youki_tommady/target/x86_64-unknown-linux-gnu/debug/build/libbpf-sys-238adb98268543af/out/obj/staticobjs/btf.o] Error 1info: when --target option is used, coverage for proc-macro and build script will not be displayed because cargo does not pass RUSTFLAGS to them
Compiling seccomp v0.1.0 (/home/runner/work/youki/youki/seccomp)
Compiling cgroups v0.1.0 (/home/runner/work/youki/youki/cgroups)
Compiling youki v0.0.1 (/home/runner/work/youki/youki)
warning: field is never read: `user_namespace`
--> src/rootless.rs:20:5
|
20 | pub(crate) user_namespace: Option<LinuxNamespace>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
warning: `youki` (lib) generated 1 warning
warning: `youki` (lib test) generated 1 warning (1 duplicate)
Finished test [unoptimized + debuginfo] target(s) in 22.04s
Running unittests (target/llvm-cov-target/x86_64-unknown-linux-gnu/debug/deps/youki-a853ea8c9159406b)need to check more deeper, or is that a known issue? that I can wait for the fix 🙇🏻♂️ |
|
Looks like a temporary issue with the package server. I restarted the workflow. |
tommady
force-pushed
the
279-increate-the-code-coverage-of-src-rootfs-part-5
branch
from
cca556b to
ad93fe0
Compare
Codecov Report
@@ Coverage Diff @@
## main #362 +/- ##
==========================================
+ Coverage 70.99% 73.22% +2.23%
==========================================
Files 48 48
Lines 7540 7721 +181
==========================================
+ Hits 5353 5654 +301
+ Misses 2187 2067 -120 |
tommady
force-pushed
the
279-increate-the-code-coverage-of-src-rootfs-part-5
branch
from
d0e4a4f to
b8210de
Compare
utam0k
reviewed
Oct 5, 2021
utam0k
reviewed
Oct 5, 2021
tommady
deleted the
279-increate-the-code-coverage-of-src-rootfs-part-5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as requested by separating #340 into small PRs
this one is the fourth part which is adding three test cases:
please help review 🙇🏻