-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement seccomp notify #384
Conversation
Codecov Report
@@ Coverage Diff @@
## main #384 +/- ##
==========================================
- Coverage 76.92% 75.83% -1.09%
==========================================
Files 52 52
Lines 8280 8402 +122
==========================================
+ Hits 6369 6372 +3
- Misses 1911 2030 +119 |
36f4ee8
to
06fc5b9
Compare
@yihuaf Cool! |
Co-authored-by: utam0k <[email protected]>
I updated the drawio.svg.
It is probably easier to do a follow up PR. Likely I have to port over "seccompagent" for the testing: |
@yihuaf Thanks for your update. I think it would be worthwhile to add the interactions between each process about seccomp/seccomp notify to the sequence diagram. What do you think? Is it difficult to add this into youki's original integration test that we are working on? I have no problem at all with another PR.
|
I can add the seccomp to the diagram. In terms of integration test, there are two layers for seccomp notify. Youki itself doesn't do much other than sending a fd through a unix domain socket to a process outside Youki, which we can certainly test. If we want to actually test the functionality of seccomp notify, we need some process (aka seccomp agent) to listen on the seccomp notify socket and approve syscalls. That is a bit more complicated to automate, but shouldn't be any issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
Note: I just realize while implementing this PR that seccomp notify is a fairly new thing that is less than a year old. seccomp v2.5.2 was released Aug 2021 and still includes changes to the seccomp notify. Likely there will be cases where we need a finer grained control over seccomp api level, which is not implemented in the PR. Most of the time, seccomp listener and notify features are not invoked, so this PR code path won't get triggered. I will iron out these kinks with follow up PRs.
Fix #307