Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented seccomp notify integration tests #435

Merged
merged 4 commits into from
Oct 25, 2021
Merged

implemented seccomp notify integration tests #435

merged 4 commits into from
Oct 25, 2021

Conversation

yihuaf
Copy link
Collaborator

@yihuaf yihuaf commented Oct 25, 2021

Fix #393

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2021 •
edited
Loading

Codecov Report

Merging #435 (a20e7c3) into main (2bbcb45) will increase coverage by 0.93%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   67.31%   68.24%   +0.93%     
==========================================
  Files          76       76              
  Lines        9747     9888     +141     
==========================================
+ Hits         6561     6748     +187     
+ Misses       3186     3140      -46

@yihuaf yihuaf requested review from Furisto, YJDoc2 and utam0k October 25, 2021 12:04
@yihuaf
Copy link
Collaborator Author

yihuaf commented Oct 25, 2021

Note: Seems like latest runc version 1.0.2 doesn't support seccomp notify. Even SCMP_ACT_NOTIFY is not a valid seccomp action, so we skip this test for runc.
Ref: https://github.com/opencontainers/runc/blob/v1.0.2/libcontainer/seccomp/config.go

@yihuaf yihuaf merged commit 77080b5 into youki-dev:main Oct 25, 2021
@yihuaf yihuaf deleted the seccomp_integration branch October 25, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Furisto Furisto Furisto approved these changes

@YJDoc2 YJDoc2 Awaiting requested review from YJDoc2

@utam0k utam0k Awaiting requested review from utam0k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement seccomp notify integration tests
3 participants
@yihuaf @codecov-commenter @Furisto