-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding benchmark execution time github action #478
adding benchmark execution time github action #478
Conversation
Codecov Report
@@ Coverage Diff @@
## main #478 +/- ##
=======================================
Coverage 60.44% 60.44%
=======================================
Files 82 82
Lines 12150 12150
=======================================
Hits 7344 7344
Misses 4806 4806 |
uses: marocchino/sticky-pull-request-comment@v2 | ||
with: | ||
append: true | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this is not enough permissions in the organization, can you change it to print in actions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK,
I'll figure out a way to print the resulting beauty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saschagrunert Hi! The youki team is trying to measure the results of a very simple benchmark (just for reference) using github actions. I'd like to comment on the results to the PR, but I don't seem to have permission. Could you ask the organizer to check it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help.
I am already the owner of this repository.
It looks like there is no write on GITHUB_TOKEN
permissions. Isn't GITHUB_TOKEN
set to read-only on the organizer side? I could not check the permissions of the organizer with my permissions. In the repository, GITHUB_TOKEN
is set to write, but it may be possible to override this permission in the organizer.
https://github.com/containers/youki/pull/478/files#diff-28fe3108ee857a8865d400d072ffeab3d06d0c14073313bd0b39cf4fa41a57fdR134-R142
Hi, so I change to print in the terminal, the result will like below in the action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great first step.
part of #464
this PR is the first part of that issue.
how to use it: