Improvements to cgroup support #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Furisto
force-pushed
the
systemd-part4
branch
from
9864db0 to
8477d48
Compare
Codecov Report
@@ Coverage Diff @@
## main #513 +/- ##
==========================================
+ Coverage 60.54% 60.86% +0.32%
==========================================
Files 86 87 +1
Lines 12604 12672 +68
==========================================
+ Hits 7631 7713 +82
+ Misses 4973 4959 -14 |
tsturzl
suggested changes
Dec 2, 2021
crates/libcgroups/src/common.rs
Outdated
|
|
||
| #[cfg(not(feature = "v1"))] | ||
| fn create_v1_cgroup_manager(_cgroup_path: PathBuf) -> Result<Box<dyn CgroupManager>> { | ||
| bail!("cgroup v1 feature is not activated"); |
There was a problem hiding this comment.
Maybe for these features we should add some context around the fact that the build excluded this feature? I know we didn't do this in the past, but maybe it's worth doing moving forward.
There was a problem hiding this comment.
I really appreciate this being broken out and put behind feature flags. I think this is much cleaner.
Furisto
force-pushed
the
systemd-part4
branch
from
8477d48 to
af4d403
Compare
|
@tsturzl PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains multiple smaller improvements that did not really warrant their own PR.