ignore integration test crate for code coverage #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #517 +/- ##
==========================================
+ Coverage 60.86% 61.12% +0.25%
==========================================
Files 87 85 -2
Lines 12672 12609 -63
==========================================
- Hits 7713 7707 -6
+ Misses 4959 4902 -57 |
utam0k
approved these changes
Dec 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you add integration tests it reduces coverage because the integration tests don't have any verifiable test on them and codecov doesn't really know that they are actually tests. So I think for now to reduce the false negatives in codecov we can just ignore the entire integration test crate for now per this document. Perhaps we can eventually figure out how to get coverage reports on the integration tests in the future, but this is a quick fix.