Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cargo.lock file that gets generated after build #734

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Fix Cargo.lock file that gets generated after build #734

merged 1 commit into from
Feb 23, 2022

Conversation

harche
Copy link
Contributor

@harche harche commented Feb 23, 2022 •
edited by gitpod-io bot
Loading

Running cargo build on the main branch generates a diff in Cargo.lock file.

Signed-off-by: Harshal Patil [email protected]

@harche harche changed the title Fix cargo file that gets generated after build Fix Cargo.lock file that gets generated after build Feb 23, 2022
@harche harche mentioned this pull request Feb 23, 2022
Merged
saschagrunert
saschagrunert approved these changes Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

utam0k
utam0k approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@utam0k
Copy link
Member

utam0k commented Feb 23, 2022

@saschagrunert Thanks for your review 🙏

@codecov-commenter
Copy link

Codecov Report

Merging #734 (8722bd9) into main (673d2e1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #734   +/-   ##
=======================================
  Coverage   72.52%   72.52%           
=======================================
  Files          86       86           
  Lines       11740    11740           
=======================================
  Hits         8515     8515           
  Misses       3225     3225

@utam0k utam0k merged commit d3f2409 into youki-dev:main Feb 23, 2022
@harche harche deleted the cargo_fix branch February 23, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utam0k utam0k utam0k approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harche @utam0k @codecov-commenter @saschagrunert