Enable animation based on navigation transitions. #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Responses can now send a `name` value which will be used to construct "from" and "to" CSS classes that will be applied during updates. These two classes will be applied with the following patterns: * `config['animation-class'] + '-from-' + _previous_name_` * `config['animation-class'] + '-to-' + _current_name_` This will allow transitions to be applied based on state of the page (i.e. navigating from page A to page B) instead of based on the action (i.e. navigating back in the history stack). Currently, a `name` must be sent with each part of a multipart response for it to be used when processing that part. The last `name` value will be saved for upcoming "from" classes. In order to initialize a "from" class before the first SPF navigation, pages can set the `data-spf-name` attribute on the `<body>` tag: ```html <body data-spf-name="home" ...> ``` Progress on youtube#299.
nicksay
added a commit
that referenced
this pull request
Mar 10, 2015
Enable animation based on navigation transitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responses can now send a
namevalue which will be used to construct "from"and "to" CSS classes that will be applied during updates. These two classes
will be applied with the following patterns:
config['animation-class'] + '-from-' + _previous_name_config['animation-class'] + '-to-' + _current_name_This will allow transitions to be applied based on state of the page (i.e.
navigating from page A to page B) instead of based on the action (i.e.
navigating back in the history stack).
Currently, a
namemust be sent with each part of a multipart response for itto be used when processing that part. The last
namevalue will be savedfor upcoming "from" classes.
In order to initialize a "from" class before the first SPF navigation, pages
can set the
data-spf-nameattribute on the<body>tag:Progress on #299.