Allow advanced users to enforce JSON response types in XHRs. #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| spf.debug.debug('nav.request.handleCompleteFromXHR_ ', | ||
| url, {'extra': chunking.extra, 'complete': xhr.responseText}); | ||
| spf.debug.debug('nav.request.handleCompleteFromXHR_ ', url, | ||
| xhr.responseType == 'json' ? |
There was a problem hiding this comment.
This line is a bit excessive. Can you determine the correct response object to log on another line and pass it in?
|
LGTM |
Add support for setting the XHR `responseType` property to `"json"`. This defines the response data as JSON and prevents the browser from handling other types of data. It allows JSON parsing to be done off of the main thread, reducing CPU contention that can happen with large responses and low-power devices; this can yield smoother animations during navigation, for example. However, it prevents processing chunked responses on-the-fly (i.e. pseudo-streaming), effectively eliminating most of the benefits of multipart responses. Guard this behavior behind an "advanced" config flag and provide no default to prevent accidental usage. Setting `advanced-response-type-json` to `true` will enable the feature. Closes youtube#317.
nicksay
force-pushed
the
response-type-json
branch
from
20473f5 to
027fc2c
Compare
nicksay
added a commit
that referenced
this pull request
Apr 16, 2015
Allow advanced users to enforce JSON response types in XHRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for setting the XHR
responseTypeproperty to"json". Thisdefines the response data as JSON and prevents the browser from handling other
types of data. It allows JSON parsing to be done off of the main thread,
reducing CPU contention that can happen with large responses and low-power
devices; this can yield smoother animations during navigation, for example.
However, it prevents processing chunked responses on-the-fly (i.e.
pseudo-streaming), effectively eliminating most of the benefits of multipart
responses. Guard this behavior behind an "advanced" config flag and provide
no default to prevent accidental usage. Setting
advanced-response-type-jsonto
truewill enable the feature.Closes #317.