Provide UMD compatibility. #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcelduran Updated to condense the pre-minified UMD wrapper. PTAL |
|
Is it possible to write tests? Perhaps simulating AMD/CommonJS environments by adding |
|
We don't have an integration test environment setup that uses the compiled code, just unit tests that use the source; so I'm going to defer on that, but it's a good idea. |
|
Fair enough. LGTM 👍 |
* Ensure build output is wrapped to support both AMD (e.g. RequireJS) and CommonJS (e.g. Browserify) module formats. * Use a dedicated wrapper.js file since the complexity has grown. * Streamline how the API is defined for both the main and bootloader binaries to reduce boilerplate. Closes youtube#40.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommonJS (e.g. Browserify) module formats.
to reduce boilerplate.
Closes #40.