[bugfix] PullRefresh: ensure value change can be watched (#3719)

youzan · Jul 2, 2019 · 5b4a4cc · 5b4a4cc
1 parent 5d5bc87
commit 5b4a4cc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/pull-refresh/index.js b/src/pull-refresh/index.js
@@ -99,10 +99,15 @@ export default createComponent({
     onTouchEnd() {
       if (!this.untouchable && this.ceiling && this.deltaY) {
         this.duration = this.animationDuration;
+
         if (this.status === 'loosing') {
           this.setStatus(this.headHeight, true);
           this.$emit('input', true);
-          this.$emit('refresh');
+
+          // ensure value change can be watched
+          this.$nextTick(() => {
+            this.$emit('refresh');
+          });
         } else {
           this.setStatus(0);
         }

diff --git a/src/pull-refresh/test/index.spec.js b/src/pull-refresh/test/index.spec.js
@@ -1,7 +1,7 @@
 import PullRefresh from '..';
-import { mount, trigger, triggerDrag } from '../../../test/utils';
+import { mount, later, trigger, triggerDrag } from '../../../test/utils';
 
-test('change head content when pulling down', () => {
+test('change head content when pulling down', async () => {
   const wrapper = mount(PullRefresh, {
     propsData: {
       value: false
@@ -32,6 +32,9 @@ test('change head content when pulling down', () => {
   expect(wrapper).toMatchSnapshot();
 
   expect(wrapper.emitted('input')).toBeTruthy();
+  expect(wrapper.emitted('refresh')).toBeFalsy();
+
+  await later();
   expect(wrapper.emitted('refresh')).toBeTruthy();
 
   // end loading