feat: add enableDoubleScale attribute #12360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjiahan
reviewed
Oct 13, 2023
package.json
Outdated
| "husky": "^8.0.1", | ||
| "nano-staged": "^0.8.0", | ||
| "prettier": "^3.0.0", | ||
| "vue": "^3.3.4" |
There was a problem hiding this comment.
为什么需要在根目录安装 Vue 和格式化 package.json 文件呢
chenjiahan
reviewed
Oct 13, 2023
| @@ -72,6 +72,7 @@ export const imagePreviewProps = { | |||
| closeOnClickOverlay: truthProp, | |||
| closeIconPosition: makeStringProp<PopupCloseIconPosition>('top-right'), | |||
| teleport: [String, Object] as PropType<TeleportProps['to']>, | |||
| enableDoubleScale: Boolean, | |||
|
我启动项目时发现要有vue的依赖，上传代码时忘记恢复了，代码格式化工具有出入，也是忘记恢复了，不好意思
…---Original---
From: ***@***.***>
Date: Fri, Oct 13, 2023 20:20 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [youzan/vant] feat: add enableDoubleSclae (PR #12360)
@chenjiahan commented on this pull request.
In package.json:
> + "*.md": "prettier --write", + "*.{ts,tsx,js,vue,less}": "prettier --write", + "*.{ts,tsx,js,vue}": "eslint --fix" + }, + "engines": { + "pnpm": ">= 8.8.0" + }, + "packageManager": ***@***.***", + "devDependencies": { + ***@***.***/cli": "workspace:*", + ***@***.***/eslint-config": "workspace:*", + "eslint": "^8.46.0", + "husky": "^8.0.1", + "nano-staged": "^0.8.0", + "prettier": "^3.0.0", + "vue": "^3.3.4"
为什么需要在根目录安装 Vue 和格式化 package.json 文件呢
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
coderXMin
changed the title
Codecov ReportAttention:
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
|
哈哈 没事~ |
chenjiahan
approved these changes
Oct 14, 2023
|
你好，以组件调用的方式使用 ImagePreview 时，并通过 image 插槽展示图片好像不支持缩放诶 |
CatsAndMice
pushed a commit
to CatsAndMice/vant
that referenced
this pull request
Apr 8, 2024
* feat: add enableDoubleSclae * feat: add enableDoubleScale attribute * Update package.json --------- Co-authored-by: neverland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat:添加了enableDoubleScale属性（默认为true），true为允许双击缩放，蒙层关闭会有250ms延迟；false为不允许双击缩放，蒙层关闭没有延迟。
解决问题：提供用户双向选择是否开启双击缩放，关闭会导致预留双击时间以致于关闭延迟，解决有些延迟效果不好而且双击缩放需求不大的场景。