fix(ImagePreview): double-scale and close-on-click-overlay may not work in certain scenarios #12521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12521 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 257 257
Lines 6801 6802 +1
Branches 1648 1647 -1
=======================================
+ Hits 6113 6114 +1
Misses 366 366
Partials 322 322 ☔ View full report in Codecov by Sentry. |
chenjiahan
approved these changes
Dec 23, 2023
chenjiahan
changed the title
|
Nice 👍🏻 |
CatsAndMice
pushed a commit
to CatsAndMice/vant
that referenced
this pull request
Apr 8, 2024
…rk in certain scenarios (youzan#12521)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the two issues below:
double-scaleis set to false,close-on-click-overlaywill not work.close-on-click-overlayis set to false, double-click zooming will not work.