-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support link css from shadow dom #12526
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12526 +/- ##
==========================================
- Coverage 89.85% 89.84% -0.02%
==========================================
Files 257 257
Lines 6802 6802
Branches 1647 1647
==========================================
- Hits 6112 6111 -1
Misses 366 366
- Partials 324 325 +1 ☔ View full report in Codecov by Sentry. |
Can you provide some example code of |
https://codesandbox.io/p/sandbox/vant-4-issue-template-forked-jk5tdd?file=%2Fsrc%2FApp.vue%3A44%2C18 |
The dependency graph of CSS is automatically generated, which means that we don't need to manually maintain the import order of CSS. |
This is not a documented approach, can we just import the <link rel="stylesheet" href="https://unpkg.com/[email protected]/es/tabs/index.css" /> |
Yes, I know this.
No,
No, The Finally, the reason why I asked the question at the above,it is to consider import on demand. |
On-demand importing should not be achieved through the use of the link tag, as the link tag is unable to deduplicate modules or manage the order of the module graph. |
So what are your thoughts on using Although |
Thanks for merging this. |
I have no idea at the moment as I have no experience with web components, but PRs are welcome for the improvement of Vant's support for web components. 😄 |
I will. Thanks for accepting this point. |
Excuse me, when is the next release date? |
I'm going to release a new version this week. |
All
:root
css variables are also added under:host
to support usinglink
tags to get css vars from Shadow DOM.If we can take all css variables extracted to a separate single css file and publish, it seems to be an another solution that can be considered.