feat(image-preview): export onLoad and style for image slot #12740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12740 +/- ##
==========================================
+ Coverage 89.81% 89.84% +0.02%
==========================================
Files 257 257
Lines 6835 6835
Branches 1660 1660
==========================================
+ Hits 6139 6141 +2
Misses 369 369
+ Partials 327 325 -2 ☔ View full report in Codecov by Sentry. |
chenjiahan
reviewed
Mar 30, 2024
| @@ -302,7 +302,7 @@ imagePreviewRef.value?.swipeTo(1); | |||
| | --- | --- | --- | | |||
| | index | Custom index | _{ index: index of current image }_ | | |||
| | cover | Custom content that covers the image preview | - | | |||
| | image | Custom image content | _{ src: current image src }_ | | |||
| | image | Custom image content | _{ src: current image src, onLoad: load image, style: current image style }_ | | |||
There was a problem hiding this comment.
Maybe we can add an example to tell user when should they use the style and onLoad
There was a problem hiding this comment.
I will merge this PR first, and feel free to open another PR for the example~
There was a problem hiding this comment.
Thanks. I've been feeling a bit unwell lately. It would be great if anyone is willing to complete this task.
There was a problem hiding this comment.
Take care of yourself ❤️
The documentation has been added: #12751
chenjiahan
approved these changes
Mar 31, 2024
This was referenced Mar 31, 2024
bluesky335
pushed a commit
to bluesky335/vant
that referenced
this pull request
Apr 1, 2024
CatsAndMice
pushed a commit
to CatsAndMice/vant
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #12656