Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NumberKeyboard): lose the number 0 key in some configs #12972

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

Whbbit1999
Copy link
Contributor

Before submitting a pull request, please read the contributing guide.

在提交 pull request 之前,请阅读 贡献指南

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (50f7889) to head (5ca8557).
Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12972      +/-   ##
==========================================
- Coverage   89.64%   89.63%   -0.01%     
==========================================
  Files         257      257              
  Lines        6979     6986       +7     
  Branches     1719     1723       +4     
==========================================
+ Hits         6256     6262       +6     
- Misses        383      386       +3     
+ Partials      340      338       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PeyFon
Copy link

PeyFon commented Sep 2, 2024

这个月还能合并更新上去吗

@chenjiahan chenjiahan changed the title fix: van-number-keyboard组件在某些配置下会丢失 数字0 键 #12950 fix: van-number-keyboard component will lose the number 0 key in some configs Sep 8, 2024
@chenjiahan chenjiahan changed the title fix: van-number-keyboard component will lose the number 0 key in some configs fix(NumberKeyboard): lose the number 0 key in some configs Sep 8, 2024
@chenjiahan chenjiahan merged commit bd90b6d into youzan:main Sep 8, 2024
5 checks passed
@PeyFon
Copy link

PeyFon commented Sep 12, 2024

不在这一版?
image

@chenjiahan
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants