Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Field): should not modify the value if it's within the min/max #13343

Merged
merged 2 commits into from
Feb 9, 2025

Conversation

inottn
Copy link
Collaborator

@inottn inottn commented Feb 9, 2025

close #13282

Added @dgmpk to co-author info.

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.62%. Comparing base (ec5b45b) to head (e047b70).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13343      +/-   ##
==========================================
+ Coverage   89.60%   89.62%   +0.02%     
==========================================
  Files         257      257              
  Lines        7013     7020       +7     
  Branches     1736     1737       +1     
==========================================
+ Hits         6284     6292       +8     
- Misses        384      385       +1     
+ Partials      345      343       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can merge these two PRs 😄

@chenjiahan chenjiahan changed the title fix(Field): should not modify the value if it's within the min/max test(Field): should not modify the value if it's within the min/max Feb 9, 2025
@chenjiahan chenjiahan enabled auto-merge (squash) February 9, 2025 12:50
@chenjiahan chenjiahan merged commit c7024d4 into youzan:main Feb 9, 2025
3 checks passed
@inottn inottn deleted the fix/field branch February 9, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants