Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] IndexBar: activeAnchor bug fixes #3832

Merged
merged 5 commits into from
Jul 12, 2019

Conversation

cfabregas
Copy link
Contributor

cfabregas and others added 3 commits July 11, 2019 22:27
修复sticky设为false时activeAnchor失效的bug;
修复this.scroller不为window时activeAnchor错乱的bug;
@codecov-io
Copy link

codecov-io commented Jul 11, 2019

Codecov Report

Merging #3832 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3832      +/-   ##
==========================================
- Coverage   93.36%   93.36%   -0.01%     
==========================================
  Files         127      127              
  Lines        2789     2788       -1     
  Branches      253      253              
==========================================
- Hits         2604     2603       -1     
  Misses        155      155              
  Partials       30       30
Impacted Files Coverage Δ
src/index-bar/index.js 96.55% <100%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aab46f...eca35d2. Read the comment docs.

cfabregas and others added 2 commits July 11, 2019 23:41
修复sticky设为false时activeAnchor失效的bug;
修复this.scroller不为window时activeAnchor错乱的bug;

index-bar bug fixed

修复sticky设为false时activeAnchor失效的bug;
修复this.scroller不为window时activeAnchor错乱的bug;

no-trailing-spaces

update snapshot
修复sticky设为false时activeAnchor失效的bug;
修复this.scroller不为window时activeAnchor错乱的bug;
@chenjiahan chenjiahan changed the title index-bar bug fixed [bugfix] IndexBar: activeAnchor bug fixes Jul 12, 2019
@chenjiahan chenjiahan merged commit c88bab2 into youzan:dev Jul 12, 2019
@chenjiahan
Copy link
Member

感谢 PR,会在 2.0.8 版本发布

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants