Only support alert rules if grafana is above version 9.4.0 #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mt3593 , @acjohnson It's great, I also tested versions like '9.4.0-beta1', the Many thanks |
|
@ysde oh didn't think about beta version, good to see the library has already thought of this. Updated readme 👍 |
|
Thank you for this @mt3593 🎉 |
|
No worries @acjohnson, anything more we need to get a release out? |
|
Not that I'm aware of @ysde if you want I can cut a release but I think with the new features it should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #201
This ensures that it only saves and restores alert rules if grafana's version is equal to or above 9.4.0.
I have tested this by running up a docker image of the various version and trying to restore and back up from each version.
How does this look @acjohnson @michyliao @ysde
This does add a dependency on to the packaging library, hope that's ok.