Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest 12.1 release fails to build on 32bit (i686 arch) #1346

Closed
david-geiger opened this issue Oct 1, 2024 · 3 comments
Closed

Latest 12.1 release fails to build on 32bit (i686 arch) #1346

david-geiger opened this issue Oct 1, 2024 · 3 comments

Comments

@david-geiger
Copy link

Hi,

On Mageia Cauldron latest release (12.1) fails to build now on i686 arch with the following build issue:

In file included from ../src/transition/script.h:5,
from ../src/wm/win.h:21,
from ../src/opengl.h:10,
from ../src/vsync.c:11:
../src/transition/script.h:48:1: error: static assertion failed: "double/unsigned has unexpected alignment"
48 | static_assert(alignof(double) > alignof(unsigned), "double/unsigned has unexpected "
| ^~~~~~~~~~~~~
In file included from ../src/wm/wm.h:15,
from ../src/wm/win.h:24:
../src/wm/wm.h:77:1: error: static assertion failed: "wm_treeid alignment is not 8 bytes"
77 | static_assert(alignof(wm_treeid) == 8, "wm_treeid alignment is not 8 bytes");

Attached full build log:
build.i686.0.20241001044804.log

@yshui yshui closed this as completed in 0ba5a7f Oct 2, 2024
@yshui
Copy link
Owner

yshui commented Oct 2, 2024

Pushed a fix, I don't have a 32bit system for testing so let me know if you still have this problem.

yshui added a commit that referenced this issue Oct 2, 2024
Force uint64_t to be aligned to 8-bytes even on 32-bit systems, so we
don't need a special case for them.

Fixes #1346

Signed-off-by: Yuxuan Shui <[email protected]>
@david-geiger
Copy link
Author

You fixed one of the two build issue, now there is still this one:

In file included from ../src/transition/script.h:5, from ../src/wm/win.h:21, from ../src/picom.h:24, from ../src/diagnostic.c:13: ../src/transition/script.h:48:1: error: static assertion failed: "double/unsigned has unexpected alignment" 48 | static_assert(alignof(double) > alignof(unsigned), "double/unsigned has unexpected "

yshui added a commit that referenced this issue Oct 2, 2024
Remove an unneeded static assertion.

Fixes #1346

Signed-off-by: Yuxuan Shui <[email protected]>
@yshui
Copy link
Owner

yshui commented Oct 2, 2024

ok i've gotten rid of that too.

honestly i don't know if picom even works on 32bit anymore.

yshui added a commit that referenced this issue Oct 10, 2024
Remove an unneeded static assertion.

Fixes #1346

Signed-off-by: Yuxuan Shui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants