Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ABI to version 0.2.0 so that it works with Envoy 1.17 #19

Merged

Conversation

nullpo-head
Copy link
Collaborator

@nullpo-head nullpo-head commented Feb 2, 2021

Summary

This PR and the accompanying change of envoy-wasm-rust-sdk allow wasm plugins to run on both wasm:1.15 and standard:1.17 version of Envoy.

PiotrSikora and others added 30 commits July 31, 2020 20:49
Signed-off-by: Shikugawa <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
While there, align style with the test framework.

Signed-off-by: Piotr Sikora <[email protected]>
Fixes yskopets#4.

Signed-off-by: Piotr Sikora <[email protected]>
While there, update Bazel to 3.7.0.

Signed-off-by: Piotr Sikora <[email protected]>
Copy link
Owner

@yskopets yskopets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 action points I'd like you to take.

Otherwise, awesome!

Thanks a lot!

src/types.rs Outdated Show resolved Hide resolved
src/types.rs Outdated Show resolved Hide resolved
@nullpo-head
Copy link
Collaborator Author

Please don't merge this yet for a while. I've messed up commits when I fixed my commits' email address and signature.

@nullpo-head nullpo-head force-pushed the feature/envoy-1.17 branch 2 times, most recently from 44344c2 to 2066490 Compare March 2, 2021 10:34
@nullpo-head
Copy link
Collaborator Author

Please don't merge this yet for a while. I've messed up commits when I fixed my commits' email address and signature.

Now they're fixed.

@yskopets yskopets merged commit 861b33b into yskopets:proxy-wasm-spec-0.1.0 Mar 2, 2021
@yskopets
Copy link
Owner

yskopets commented Mar 2, 2021

@nullpo-head Thank you!

github-actions bot pushed a commit that referenced this pull request Mar 2, 2021
* Use Rust toolchains with working components. (#16)

Signed-off-by: Piotr Sikora <[email protected]>

* Split licenses check into a separate test target. (#17)

Signed-off-by: Piotr Sikora <[email protected]>

* Help other developers get started using this SDK. (#15)

Signed-off-by: DazWilkin <[email protected]>

* Add Bazel support. (#18)

Signed-off-by: Shikugawa <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>

* Add support for setting HTTP bodies. (#2)

Signed-off-by: Gregory Brail <[email protected]>

* Release v0.1.1. (#20)

Signed-off-by: Piotr Sikora <[email protected]>

* Update MapType values to match updated Proxy-Wasm ABI v0.1.0. (#7)

Signed-off-by: Yaroslav Skopets <[email protected]>

* Release v0.1.2. (#21)

Signed-off-by: Piotr Sikora <[email protected]>

* Update hashbrown to v0.8.2. (#22)

Signed-off-by: Piotr Sikora <[email protected]>

* Add cargo audit and cargo outdated checks. (#23)

Signed-off-by: Piotr Sikora <[email protected]>

* Update chrono to v0.4.15. (proxy-wasm#33)

Signed-off-by: Piotr Sikora <[email protected]>

* Move optional checks to the end. (proxy-wasm#28)

While there, align style with the test framework.

Signed-off-by: Piotr Sikora <[email protected]>

* Move Bazel to //bazel. (proxy-wasm#29)

Signed-off-by: Piotr Sikora <[email protected]>

* Fix HTTP body example. (proxy-wasm#32)

Signed-off-by: Piotr Sikora <[email protected]>

* Add support for setting network buffers. (proxy-wasm#31)

Signed-off-by: Piotr Sikora <[email protected]>

* Add metrics. (proxy-wasm#30)

Fixes #4.

Signed-off-by: Piotr Sikora <[email protected]>

* Update hashbrown and transitive dependencies. (proxy-wasm#45)

Signed-off-by: Piotr Sikora <[email protected]>

* Allow building for wasm32-wasi target. (proxy-wasm#42)

Signed-off-by: Piotr Sikora <[email protected]>

* Make wee-alloc an optional feature. (proxy-wasm#38)

Signed-off-by: Yuval Kohavi <[email protected]>

* Update rules_rust to latest. (proxy-wasm#46)

Signed-off-by: Piotr Sikora <[email protected]>

* Update cargo-raze to latest and regenerate artifacts. (proxy-wasm#47)

Signed-off-by: Piotr Sikora <[email protected]>

* Allow building for wasm32-wasi target using Bazel. (proxy-wasm#50)

While there, update Bazel to 3.7.0.

Signed-off-by: Piotr Sikora <[email protected]>

* Show getrandom and chrono/time usage in examples. (proxy-wasm#51)

Signed-off-by: Piotr Sikora <[email protected]>

* Use cargo-raze's gen_buildrs for trusted crates. (proxy-wasm#53)

Signed-off-by: Piotr Sikora <[email protected]>

* Add support for nested HTTP callouts. (proxy-wasm#56)

Signed-off-by: Svetlin Zarev <[email protected]>

* Allow RootContext to create child contexts for streams. (proxy-wasm#34)

Fixes #6.

Signed-off-by: Daniel Grimm <[email protected]>

* Fix warnings from Clippy v1.50.0 (nightly). (proxy-wasm#58)

Signed-off-by: Piotr Sikora <[email protected]>

* Release v0.1.3. (proxy-wasm#59)

Signed-off-by: Piotr Sikora <[email protected]>

* Cleanup instructions for updating dependencies. (proxy-wasm#60)

Signed-off-by: Piotr Sikora <[email protected]>

* Cleanup WORKSPACE. (proxy-wasm#61)

Signed-off-by: Piotr Sikora <[email protected]>

* Cleanup examples. (proxy-wasm#62)

Signed-off-by: Piotr Sikora <[email protected]>

* Update libc (transitive dependency) to v0.2.81. (proxy-wasm#63)

Signed-off-by: Piotr Sikora <[email protected]>

* Update the declared ABI version to 0.2.0

Signed-off-by: Takaya Saeki <[email protected]>

* Update the examples so that they use the latest API

Signed-off-by: Takaya Saeki <[email protected]>

* Remove ChildContext for now, which is not used anymore

Signed-off-by: Takaya Saeki <[email protected]>

* Bump the version to 0.0.8

Signed-off-by: Takaya Saeki <[email protected]>

* Fix bazel build for the fork's crate

Signed-off-by: Takaya Saeki <[email protected]>

* Fix clippy erros in bytestring.rs

Signed-off-by: Takaya Saeki <[email protected]>

* Update dependencies

Signed-off-by: Takaya Saeki <[email protected]>

* Fix Cargo.toml

Signed-off-by: Takaya Saeki <[email protected]>

* outdated should check only root deps

Signed-off-by: Takaya Saeki <[email protected]>

* Fix inconsistent derived traits

Signed-off-by: Takaya Saeki <[email protected]>

Co-authored-by: Piotr Sikora <[email protected]>
Co-authored-by: Daz Wilkin <[email protected]>
Co-authored-by: Greg Brail <[email protected]>
Co-authored-by: Yaroslav Skopets <[email protected]>
Co-authored-by: Yuval Kohavi <[email protected]>
Co-authored-by: SvetlinZarev-SAP <[email protected]>
Co-authored-by: Daniel Grimm <[email protected]>
github-actions bot pushed a commit to nullpo-head/proxy-wasm-rust-sdk that referenced this pull request Apr 20, 2021
…opets#19)

* Use Rust toolchains with working components. (yskopets#16)

Signed-off-by: Piotr Sikora <[email protected]>

* Split licenses check into a separate test target. (yskopets#17)

Signed-off-by: Piotr Sikora <[email protected]>

* Help other developers get started using this SDK. (yskopets#15)

Signed-off-by: DazWilkin <[email protected]>

* Add Bazel support. (yskopets#18)

Signed-off-by: Shikugawa <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>

* Add support for setting HTTP bodies. (yskopets#2)

Signed-off-by: Gregory Brail <[email protected]>

* Release v0.1.1. (yskopets#20)

Signed-off-by: Piotr Sikora <[email protected]>

* Update MapType values to match updated Proxy-Wasm ABI v0.1.0. (yskopets#7)

Signed-off-by: Yaroslav Skopets <[email protected]>

* Release v0.1.2. (yskopets#21)

Signed-off-by: Piotr Sikora <[email protected]>

* Update hashbrown to v0.8.2. (yskopets#22)

Signed-off-by: Piotr Sikora <[email protected]>

* Add cargo audit and cargo outdated checks. (yskopets#23)

Signed-off-by: Piotr Sikora <[email protected]>

* Update chrono to v0.4.15. (proxy-wasm#33)

Signed-off-by: Piotr Sikora <[email protected]>

* Move optional checks to the end. (proxy-wasm#28)

While there, align style with the test framework.

Signed-off-by: Piotr Sikora <[email protected]>

* Move Bazel to //bazel. (proxy-wasm#29)

Signed-off-by: Piotr Sikora <[email protected]>

* Fix HTTP body example. (proxy-wasm#32)

Signed-off-by: Piotr Sikora <[email protected]>

* Add support for setting network buffers. (proxy-wasm#31)

Signed-off-by: Piotr Sikora <[email protected]>

* Add metrics. (proxy-wasm#30)

Fixes yskopets#4.

Signed-off-by: Piotr Sikora <[email protected]>

* Update hashbrown and transitive dependencies. (proxy-wasm#45)

Signed-off-by: Piotr Sikora <[email protected]>

* Allow building for wasm32-wasi target. (proxy-wasm#42)

Signed-off-by: Piotr Sikora <[email protected]>

* Make wee-alloc an optional feature. (proxy-wasm#38)

Signed-off-by: Yuval Kohavi <[email protected]>

* Update rules_rust to latest. (proxy-wasm#46)

Signed-off-by: Piotr Sikora <[email protected]>

* Update cargo-raze to latest and regenerate artifacts. (proxy-wasm#47)

Signed-off-by: Piotr Sikora <[email protected]>

* Allow building for wasm32-wasi target using Bazel. (proxy-wasm#50)

While there, update Bazel to 3.7.0.

Signed-off-by: Piotr Sikora <[email protected]>

* Show getrandom and chrono/time usage in examples. (proxy-wasm#51)

Signed-off-by: Piotr Sikora <[email protected]>

* Use cargo-raze's gen_buildrs for trusted crates. (proxy-wasm#53)

Signed-off-by: Piotr Sikora <[email protected]>

* Add support for nested HTTP callouts. (proxy-wasm#56)

Signed-off-by: Svetlin Zarev <[email protected]>

* Allow RootContext to create child contexts for streams. (proxy-wasm#34)

Fixes yskopets#6.

Signed-off-by: Daniel Grimm <[email protected]>

* Fix warnings from Clippy v1.50.0 (nightly). (proxy-wasm#58)

Signed-off-by: Piotr Sikora <[email protected]>

* Release v0.1.3. (proxy-wasm#59)

Signed-off-by: Piotr Sikora <[email protected]>

* Cleanup instructions for updating dependencies. (proxy-wasm#60)

Signed-off-by: Piotr Sikora <[email protected]>

* Cleanup WORKSPACE. (proxy-wasm#61)

Signed-off-by: Piotr Sikora <[email protected]>

* Cleanup examples. (proxy-wasm#62)

Signed-off-by: Piotr Sikora <[email protected]>

* Update libc (transitive dependency) to v0.2.81. (proxy-wasm#63)

Signed-off-by: Piotr Sikora <[email protected]>

* Update the declared ABI version to 0.2.0

Signed-off-by: Takaya Saeki <[email protected]>

* Update the examples so that they use the latest API

Signed-off-by: Takaya Saeki <[email protected]>

* Remove ChildContext for now, which is not used anymore

Signed-off-by: Takaya Saeki <[email protected]>

* Bump the version to 0.0.8

Signed-off-by: Takaya Saeki <[email protected]>

* Fix bazel build for the fork's crate

Signed-off-by: Takaya Saeki <[email protected]>

* Fix clippy erros in bytestring.rs

Signed-off-by: Takaya Saeki <[email protected]>

* Update dependencies

Signed-off-by: Takaya Saeki <[email protected]>

* Fix Cargo.toml

Signed-off-by: Takaya Saeki <[email protected]>

* outdated should check only root deps

Signed-off-by: Takaya Saeki <[email protected]>

* Fix inconsistent derived traits

Signed-off-by: Takaya Saeki <[email protected]>

Co-authored-by: Piotr Sikora <[email protected]>
Co-authored-by: Daz Wilkin <[email protected]>
Co-authored-by: Greg Brail <[email protected]>
Co-authored-by: Yaroslav Skopets <[email protected]>
Co-authored-by: Yuval Kohavi <[email protected]>
Co-authored-by: SvetlinZarev-SAP <[email protected]>
Co-authored-by: Daniel Grimm <[email protected]>
nullpo-head added a commit to nullpo-head/proxy-wasm-rust-sdk that referenced this pull request Apr 20, 2021
@nullpo-head nullpo-head mentioned this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants